-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write lyrics to id3 tag #23
Comments
I tried using mutagen and it was working quite well (you can find it on the experimental branch). Unfortunatly, Rhythmbox 3 uses Python 3 and mutagen is not available there, so I won't put any more efforts in this. Perhaps I will find another easy way to do it someday. |
I have found two library that support python 3. https://github.com/LordSputnik/mutagen and https://code.google.com/p/stagger/. |
Cool, the first one looks promising. I might try that. It's not my highest priority at the moment, but I'm definitely planning to implement this someday! |
I planing to do it too! Have you written some code that could help me as you are saying that you used mutagen before? |
me again - mutagenx works very well - the syntax is identical to python2 mutagen and I would warmly recommend using this. I use this on coverart here - the same code works on both python 2 based RB2.96-2.99 and python3 based RB3 |
You can find my attempt using mutagen for python 2 in the experimental branch, mainly here: |
I have implemented this and the changed the search method. The search method as next :
The xml file contains the informations :
the code is here https://drive.google.com/file/d/0B25ViosYm6ByY3l5VHJnVkdjQ28/edit?usp=sharing Edit : |
First, thanks for your work! To be honest, these are some big changes and I currently don't have the time to review them all. I have had a look at your downloadAllLyrics and had some small issues, but I don't remember them in detail. It would be easier for me to merge your changes, if you could submit a pull request: https://help.github.com/articles/using-pull-requests I'm looking forward to your final version and I hope I will find some time to test it properly. I will give you feedback as soon as I can. |
So to make a pull request I must fork you project? I will do it when I have some time. Are you ok with the new search method? |
That feature would be super amazing! 👍 It would also be nice to show the lyrics that are included in the tags (if the lyrics couldn't be found). |
Add an option to write the lyrics to the lyrics tag of the audio file. Python mutagen can be used for it.
The text was updated successfully, but these errors were encountered: