From 049034c32c5104f4741bf69228ef96f391c8122e Mon Sep 17 00:00:00 2001 From: Dmitry Mikhin Date: Fri, 2 Aug 2024 17:22:27 +0300 Subject: [PATCH] fix for #1239 full_label(name + "_fg") may produce different result then (name + "_fg") (name + "_fg") is used in srcs attr, so we make cmd attr to use the same value. --- foreign_cc/utils.bzl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/foreign_cc/utils.bzl b/foreign_cc/utils.bzl index 95532b094..60b09cf9a 100644 --- a/foreign_cc/utils.bzl +++ b/foreign_cc/utils.bzl @@ -52,7 +52,7 @@ def runnable_binary(name, binary, foreign_cc_target, match_binary_name = False, srcs = ["@rules_foreign_cc//foreign_cc/private:runnable_binary_wrapper.sh", name + "_fg"], outs = [name + "_wrapper.sh"], cmd = select({ - "@platforms//os:windows": wrapper_cmd.format(name = full_label(name + "_fg"), sh_binary_filename = binary + ".exe" if match_binary_name else name), + "@platforms//os:windows": wrapper_cmd.format(name = (name + "_fg"), sh_binary_filename = binary + ".exe" if match_binary_name else name), "//conditions:default": wrapper_cmd.format(name = full_label(name + "_fg"), sh_binary_filename = binary if match_binary_name else name), }), tags = tags + ["manual"],