-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auto-merge-squash drops all commit messages #66
Comments
Has been disabled for now by removing the auto-merge-squash labels. Should stay removed until dlang-bot learns to synthesized the correct commit message or can do |
Should we just include a list of commits and their commit messages in the merge commit message, then? |
Usually we use squash when a contributor doesn't have a proper commit separation - e.g. create 30 commits as the result of review. So IMO we should pick the PR title / body instead. |
Github's squash and merge button suggests all of the commit titles, but strips merge requests. Not sure about
[squash]
and!fixup
commit messages, but would be sensible to strip those as well.The text was updated successfully, but these errors were encountered: