Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

druntime tests can fail due to not having rebuilt phobos #364

Open
dhasenan opened this issue Dec 14, 2018 · 0 comments
Open

druntime tests can fail due to not having rebuilt phobos #364

dhasenan opened this issue Dec 14, 2018 · 0 comments

Comments

@dhasenan
Copy link

https://buildkite.com/dlang/dmd/builds/3182#c8f1ded2-a08a-4459-b71a-6dc737caae38 as an example. The error listed is:

benchmark/runbench.d:(.text._D3std3uni__T14findUnicodeSetS_DQBe8internal14unicode_tables6blocks3tabFNaNdNfZAySQDcQByQBs15UnicodePropertyTaZQDuFNaNfMxAaZl[_D3std3uni__T14findUnicodeSetS_DQBe8internal14unicode_tables6blocks3tabFNaNdNfZAySQDcQByQBs15UnicodePropertyTaZQDuFNaNfMxAaZl]+0x11): undefined reference to `_D3std8internal14unicode_tables6blocks3tabFNaNdNfZAySQBzQByQBs15UnicodeProperty'

This is because the PR under test changed attribute propagation, which changed the mangled name in std.internal.unicode_tables. The new mangled name didn't exist in the pre-existing libphobos, so there was a linker error when trying to build the benchmark tool.

The druntime build should build phobos and use that newly built phobos to build the benchmark tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant