Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try marking ct_eq, conditional_select, conditional_negate with #[inline] #1088

Open
divergentdave opened this issue Jul 1, 2024 · 0 comments

Comments

@divergentdave
Copy link
Contributor

Reviewing recent changes to the subtle crate brought it to my attention that the ConstantTimeEq, ConditionallySelectable, and ConditionallyNegatable traits suggest using the #[inline] attribute on implementations of their methods. This is recommended for performance reasons, see dalek-cryptography/subtle@5a8d66c. We should try this out, particularly on shorter such methods, and see if it has a meaningful impact on benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant