Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/ENS Integration #700

Open
madvas opened this issue Jun 6, 2021 · 6 comments
Open

feature/ENS Integration #700

madvas opened this issue Jun 6, 2021 · 6 comments
Labels
feature New feature or request hackathon

Comments

@madvas
Copy link
Contributor

madvas commented Jun 6, 2021

Prize Bounty

A winning hackathon submission may be awarded up to a $6,000 prize for this issue. The prize will be paid in USDC.

Bounties will be paid out at the discretion of the judges exclusively and we reserve the right to not give a bounty payment if we believe the submissions do not meet the criteria or are otherwise unfit for development.

Challenge Description

To improve UX of MemeFactory, user addresses throughout the app should reverse-resolve into ENS names, if any assigned.

First, let's look at all places in UI where addresses should be replaced with ENS names:

1. Address of a connected wallet. Code reference here.

2. Seller address, when flipping meme card that's on sale. Code reference here.

3. Creator address at Meme Detail page. Code reference here.

4. Creator and Challenger addresses at Vote/Challenge pages. Code reference here.

5. Creator address on flipped card at Dankest Memes page. Code reference here.

6. Addresses at Creator, Collectors, Curators pages. Code references here, here and here.

7. MemeFolio Page. It should say "[ENS Name] Memefolio". Code reference here.

8. Buyer address at Memefolio page Sold tab. Code reference here.

I suggest implementation as follows: On each of these places replace address with new reagent component (e.g ens-resolved-address). This component will use lifecycle method :component-did-mount, from which it'll dispatch re-frame event to request ENS name from ReverseRegistrar for given address. Once resolved name arrives, it's stored in re-frame db and through the subscriptions it's supplied to the components. UI should always display address as a fallback, either during ENS name request processing or if ENS name is not available.

Submission Requirements

Submissions are required to make Pull Request into Memefactory repository. Pull Request should include brief description about what has been done plus screenshots of relevant Memefactory UI.

Judging Criteria

district0x team members will pick 1 winning implementation, that satisfies our requirements the most. Aspects considered during the judgement are: functionality, UI styling and code quality.

Winner Announcement Date

The district0x team will decide on a winning implementation within 7 days of the close of the hackathon. Winners will be announced by 11:59PM PST on Wednesday, July 14th.

Resources

To reach our assistance please join our discord at https://discord.gg/FqWuPSEY

For more information on the district0x project, start with https://onboarding.district0x.io/

@madvas madvas added feature New feature or request hackathon labels Jun 6, 2021
@madvas madvas changed the title feature/Resolve user addresses into ENS names feature/ENS Integration Jun 9, 2021
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 6000.0 OTHER attached to it.

@gitcoinbot
Copy link

gitcoinbot commented Jun 16, 2021

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 6 hours ago.
Please review their action plans below:

1) giddyphysicist has started work.

I plan on implementing the ENS integration into the meme factory code base in the requested locations. I will look into developing a general business logic function to resolve the address to it's ENS name, and then implement the solution in the different locations on the requested front end code base. I have experience with web3, React, Solidity, and Common Lisp (similar to clojure), and am very interested in starting this project. I am open to collaborating on the project.
2) ginesdt has started work.

I plan to make a Pull Request with the required modifications to integrate MemeFactory into ENS for reverse-resolution

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 6000.0 USDC (6000.0 USD @ $1.0/USDC) has been submitted by:


touhonoob added a commit to touhonoob/memefactory that referenced this issue Jul 6, 2021
touhonoob added a commit to touhonoob/memefactory that referenced this issue Jul 6, 2021
touhonoob added a commit to touhonoob/memefactory that referenced this issue Jul 6, 2021
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 6000.0 USDC (6000.00 USD @ $1.0/USDC) has been submitted by:


touhonoob added a commit to touhonoob/memefactory that referenced this issue Jul 6, 2021
@ginesdt ginesdt mentioned this issue Jul 6, 2021
@gitcoinbot
Copy link

gitcoinbot commented Jul 6, 2021

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 6000.0 USDC (6000.00 USD @ $1.0/USDC) has been submitted by:

  1. @touhonoob
  2. @ginesdt

@henrimahal please take a look at the submitted work:


@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 6000.0 USDC (6000.00 USD @ $1.0/USDC) attached to this issue has been approved & issued to @ginesdt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request hackathon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants