Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

May DiscussionEmbedConfig type need remoteAuthS3 field? #151

Open
coiger opened this issue Nov 5, 2023 · 0 comments
Open

May DiscussionEmbedConfig type need remoteAuthS3 field? #151

coiger opened this issue Nov 5, 2023 · 0 comments

Comments

@coiger
Copy link

coiger commented Nov 5, 2023

Describe the bug

// https://github.com/disqus/disqus-react/blob/master/src/DiscussionEmbed.jsx#L81
getDisqusConfig(config) {
    return function () {
        ...
        this.page.remote_auth_s3 = config.remoteAuthS3;
        this.page.api_key = config.apiKey;
        ...
    };
}

In DiscussionEmbed components, it use remoteAuthS3 field in config props.
However, there is no remoteAuthS3 field in DiscussionEmbedConfig => results: type error

  • See here to find DiscussiongEmbeConfig type definition.

To Reproduce

<DiscussionEmbed
  shortname='EXAMPLE'
  config={{
    ...
    remoteAuthS3: 'abcdefg....',
    apiKey: 'hijklmn...',
  }}
/>
  • If I pass config.remoteAuthS3 props to DiscussionEmbed component, typescript make error
    • there is no remoteAuthS3 in config props.

Expected behavior

  • DiscussionEmbed component may need remoteAuthS3 field in config props.
  • == DiscussionEmbedConfig type may need remoteAuthS3 field.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant