Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to oeis2 #367

Open
byorgey opened this issue May 24, 2023 · 1 comment
Open

Switch to oeis2 #367

byorgey opened this issue May 24, 2023 · 1 comment
Labels
C-Moderate Effort Should take a moderate amount of time to address. S-Nice to have Minor importance

Comments

@byorgey
Copy link
Member

byorgey commented May 24, 2023 •
edited
Loading

The OEIS integration currently doesn't work --- the OEIS calls all just return Nothing. It seems that the oeis library hasn't been updated in a while, and there is a newer library oeis2 which is more up-to-date and also has additional features. We should try switching to oeis2. Currently, however, it does not build with aeson-2. See 23prime/oeis2#6 . (Edit to add: oeis2 has been updated now. Be sure to use version 1.0.9 or later, 1.0.8 had a bug.)
@byorgey byorgey added C-Moderate Effort Should take a moderate amount of time to address. S-Nice to have Minor importance labels May 24, 2023
byorgey added a commit that referenced this issue May 24, 2023
@byorgey
temporarily disable OEIS test
1f189e3 
See #367.
byorgey added a commit that referenced this issue May 24, 2023
@byorgey
Also temporarily disable pretty-issue258 (#367)
2574de3
@byorgey
Copy link
Member Author

byorgey commented May 24, 2023

Note, when fixing OEIS support, be sure to reinstate various things in failing

  • oeis.disco -> lib
  • catalan.disco -> example
  • lib-oeis -> test
  • pretty-issue258 -> test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Moderate Effort Should take a moderate amount of time to address. S-Nice to have Minor importance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@byorgey