Should we be setting NUXT_PUBLIC_SITE_URL or should we use SITE_URL in nuxt.config instead?

[Natetronn]

Hey Bryant, is there a reason you're using NUXT_PUBLIC_SITE_URL instead of SITE_URL in nuxt.config.ts ?

https://github.com/directus-labs/agency-os/blob/main/nuxt.config.ts#L48 - this one in particular
https://github.com/directus-labs/agency-os/blob/main/nuxt.config.ts#L56
https://github.com/directus-labs/agency-os/blob/main/nuxt.config.ts#L100

We ran into an issue with the og:image meta wasn't working properly, since this env var wasn't set in the .env file; it wasn't mentioned in the README here; only the SITE_URL env var is mentioned.

You can see the discrepancy on your own site as well:

Looks like NUXT_PUBLIC_SITE_URL is being passed to the Vercel deploy button in the README, but NUXT_PUBLIC_SITE_URL is more of an override for Nuxt SEO - OG Image Installation.

With that, I guess the real question is, should this be changed in code to use SITE_URL instead of NUXT_PUBLIC_SITE_URL or should we add NUXT_PUBLIC_SITE_URL to the list of required env vars and leave the code as is?

Happy to send over a PR after I better understand what's happening here.

[Natetronn]

I went ahead and submitted a PR:

#85