Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NF: Add array parsing capabilities to the CLIs #2299

Closed
areeshatariq opened this issue Nov 27, 2020 · 6 comments
Closed

NF: Add array parsing capabilities to the CLIs #2299

areeshatariq opened this issue Nov 27, 2020 · 6 comments

Comments

@areeshatariq
Copy link
Contributor

Description

Add array parsing capabilities to the CLIs (e.g. that would allow to get coherent segmentations with the dipy_median_otsu command) .
Once this is fixed, the screenshots in the following PRs would need to be generated and included in #2275
dipy/dipy_data#29
dipy/dipy_data#30
dipy/dipy_data#31
dipy/dipy_data#32
dipy/dipy_data#33

@skoudoro skoudoro added this to the 1.4 milestone Nov 27, 2020
@skoudoro skoudoro removed this from the 1.4 milestone Mar 15, 2021
@skoudoro
Copy link
Member

Hi @areeshatariq, Hi @jhlegarreta,

I do not remember what needs to be done here. I do not really understand the issue. Can one of you clarify the problem here?

Thanks!

@jhlegarreta
Copy link
Contributor

If I remember correctly, array-like arguments are not parsed correctly by the CLIs. For the CLI that raised this issue, the vol_idx argument should accept None or array-like arguments, and it looked not to be parsing those correctly. Should be reproducible by calling the CLI at issue and checking if they are parsed correctly. Sorry for not being more specific.

I guess the problem is common to all CLIs, so processing arguments of this type at a single place would be best.

If I remember correctly, at the time you already had implemented a tentative fix locally that needed more testing.

@skoudoro
Copy link
Member

I tried this: dipy_median_otsu ~/.dipy/cfin_multib/__DTI_AX_ep2d_2_5_iso_33d_20141015095334_4.nii --vol_idx 0 2 4 6

and it works as expected. not sure what was the issue, I can not reproduce it.

@skoudoro
Copy link
Member

skoudoro commented Apr 19, 2021

ok, I found a little issue but not related.

it seems we have an issue with median_otsu and stanford_hardi data. The result looks bad. I tried

dipy_median_otsu ~/.dipy/stanford_hardi/HARDI150.nii.gz --vol_idx 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 --out_dir "stanford_hardi_mask" --force --numpass 1 --dilate 2 --median_radius 3 --autocrop

I think we should rename this issue.

EDIT: dipy_horizon ~/.dipy/stanford_hardi/HARDI150.nii.gz: The data look a bit strange so the mask seems normal finally

@drombas
Copy link
Contributor

drombas commented Apr 24, 2021

Hi @skoudoro,

In case it helps. This is what I get:

image

Don't both look incomplete/strange ? especially the B, which is taking non-brain regions in. It might be worth checking how that affects the entire tutorial.

@skoudoro
Copy link
Member

closing in favor of #3176

Tutorials need to be checked. Other PR's exists for this task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants