From 319a512594a690a9363df0beb3e9e137e8e3f901 Mon Sep 17 00:00:00 2001 From: Jonathan Tang Date: Thu, 5 Sep 2024 00:00:36 -0700 Subject: [PATCH 1/3] adds helper function to get session update status --- src/cli/java/org/commcare/util/screen/SyncScreen.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/cli/java/org/commcare/util/screen/SyncScreen.java b/src/cli/java/org/commcare/util/screen/SyncScreen.java index 73a287e29..b8ad38c6a 100644 --- a/src/cli/java/org/commcare/util/screen/SyncScreen.java +++ b/src/cli/java/org/commcare/util/screen/SyncScreen.java @@ -125,6 +125,10 @@ public void updateSessionOnSuccess() { sessionWrapper.addExtraToCurrentFrameStep(EXTRA_POST_SUCCESS, true); } + public Object getSessionSuccessStatus() { + return sessionWrapper.getCurrentFrameStepExtra(EXTRA_POST_SUCCESS); + } + @Override public String[] getOptions() { return new String[0]; From 9e13cab7e642470b5d0ea7d91f6ff8811d2da1d1 Mon Sep 17 00:00:00 2001 From: Jonathan Tang Date: Tue, 10 Sep 2024 10:59:50 -0700 Subject: [PATCH 2/3] represent more literally what we are using this to check --- src/cli/java/org/commcare/util/screen/SyncScreen.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/cli/java/org/commcare/util/screen/SyncScreen.java b/src/cli/java/org/commcare/util/screen/SyncScreen.java index b8ad38c6a..00dffc3a3 100644 --- a/src/cli/java/org/commcare/util/screen/SyncScreen.java +++ b/src/cli/java/org/commcare/util/screen/SyncScreen.java @@ -125,8 +125,8 @@ public void updateSessionOnSuccess() { sessionWrapper.addExtraToCurrentFrameStep(EXTRA_POST_SUCCESS, true); } - public Object getSessionSuccessStatus() { - return sessionWrapper.getCurrentFrameStepExtra(EXTRA_POST_SUCCESS); + public Boolean isPostAlreadyDone() { + return sessionWrapper.getCurrentFrameStepExtra(EXTRA_POST_SUCCESS) == null ; } @Override From dd9c8b08a0687e47916f30eaa7078089c4196bae Mon Sep 17 00:00:00 2001 From: Jonathan Tang Date: Wed, 11 Sep 2024 08:43:46 -0700 Subject: [PATCH 3/3] fix typo and clarify function name --- src/cli/java/org/commcare/util/screen/SyncScreen.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/cli/java/org/commcare/util/screen/SyncScreen.java b/src/cli/java/org/commcare/util/screen/SyncScreen.java index 00dffc3a3..3994357e1 100644 --- a/src/cli/java/org/commcare/util/screen/SyncScreen.java +++ b/src/cli/java/org/commcare/util/screen/SyncScreen.java @@ -125,8 +125,8 @@ public void updateSessionOnSuccess() { sessionWrapper.addExtraToCurrentFrameStep(EXTRA_POST_SUCCESS, true); } - public Boolean isPostAlreadyDone() { - return sessionWrapper.getCurrentFrameStepExtra(EXTRA_POST_SUCCESS) == null ; + public Boolean isPostAlreadyAttempted() { + return sessionWrapper.getCurrentFrameStepExtra(EXTRA_POST_SUCCESS) != null ; } @Override