Make language slug available via session metadata (formplayer branch) #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minhaminha
requested review from
snopoke,
MartinRiese,
Robert-Costello and
Jtang-1
3 tasks
MartinRiese
reviewed
Oct 10, 2024
| @@ -279,7 +279,7 @@ public void setID(int recordid) { | |||
| this.recordid = recordid; | |||
| } | |||
|
|
|||
| public abstract DataInstance initialize(InstanceInitializationFactory initializer, String instanceId); | |||
| public abstract DataInstance initialize(InstanceInitializationFactory initializer, String instanceId, String locale); | |||
There was a problem hiding this comment.
Could you not create a concrete method with the original signature which calls the abstract one with the locale being null? Then you would not have to pass the null everywhere.
There was a problem hiding this comment.
Very true! This did indeed get rid of some unnecessary null usage 🎉
…es) to avoid putting so many null values into argument lists
MartinRiese
approved these changes
Oct 10, 2024
|
duplicate this PR |
Robert-Costello
approved these changes
Oct 16, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
Users will now be able to reference the current language slug (i.e. 'en', 'es', etc.) on the screen by referencing
instance('commcaresession')/session/context/applanguageTechnical Summary
Associated formplayer PR
This is the commcare-core side of the changes which:
EntityScreenContextclass to be able to carry and get the stored locale value (first initialized from withinnavigateSessionWithAuth), which allows it to be accessed during different parts of the response creation process.generateRootpath such thatlocaleis eventually added to the session root under metadata.setupSessionData, which eventually leads to callingaddMetadata, now also with a required 'locale' arguement.navigateSessionWithAuthrequest to use null values instead).Safety Assurance
Safety story
This shouldn't impact existing data since the objects surrounding session context is constantly being recreated with updated information from formplayer and most of the time the
localevalue will be set to null.QA Plan
No plans for QA but will have delivery (who request this feature) do some testing to ensure it's doing what they want.
Special deploy instructions
Rollback instructions
Review
Duplicate PR
Automatically duplicate this PR as defined in contributing.md.
(Doing this after this PR gets approved)