-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move doctl config into this library? #666
Comments
Hi @flyinprogrammer, Offering standardized way for DigitalOcean credentials to be accessed locally is a great idea. Though there are a number of issues with the current doctl config format around context handling in particular that may require breaking changes to resolve in the future. So I'd be reluctant to standardize on it in its current state. There is also a lot of very doctl specific config in that file. So in the long run, we'd probably want to consider if it make sense to handle credentials separately from other config rather than intermingling them. We'll keep this request open for tracking interest and discussion. When we're able to prioritize rethinking doctl config format, we can consider what a more standardized approach could look like. Thanks for the feedback! |
Glad to know someone is thinking about this! I appreciate keeping the issue open, it's also completely reasonable to close it now or down the line, my feelings won't be hurt. I'm also glad I didn't start working on a PR 😉 🤗 |
https://github.com/digitalocean/doctl/blob/570dda1f891eaec95a7a4867dcd418dac980897c/commands/doit.go#L32
Would it make sense to move the doctl context and access-token config code into this library so that tools that use godo have "one way" to get things like a context and access token?
similar to AWS and their standardized credentials: https://docs.aws.amazon.com/sdkref/latest/guide/standardized-credentials.html
The text was updated successfully, but these errors were encountered: