-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubernetes surge_upgrade
field cannot be set to false
#524
Comments
hello @pcman312 . thank you for the bug report. I've passed this on to the relative team and will have an answer for you shortly. |
Closing this PR out: at this point, enabling surge upgrades should come with no disadvantages anymore, neither financially nor functionally. We'll officially deprecate the flag going forward. |
Actually, reopening to track the deprecation still. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
tl;dr: The
SurgeUpgrade
field inKubernetesClusterUpdateRequest
should not haveomitempty
in the struct tags. This is preventing users from turning offsurge_upgrade
after the K8S cluster has been created.Reproduction steps:
surge_upgrade
field is set to truesurge_upgrade
Expected result:
surge_upgrade
should be turned offActual result:
surge_upgrade
is still onIt may be worthwhile looking for other non-pointer booleans with
omitempty
on them as well to check if they have the same issue.The text was updated successfully, but these errors were encountered: