-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qmp: add Monitor which uses cgo bindings to interact with libvirt #30
Comments
I've been looking into this issue and here is one idea on addressing the build tag guard. libvirtgo_linux.go (this file contains the calls to libvirt-go package) libvirtgo_others.go [build tag: // +build !linux](this file contains operations returning error stubs) Does this make sense? |
Yep, seems reasonable to me. I'm happy as long as it compiles on all platforms, even if every method returns an error when not running on Linux. |
I'm getting closer to a PR for this issue. As for the dependency to the libvirt-go package, would Go 1.5+ vendoring suffice? |
Since we are providing packages and not an application, we don't explicit vendor our dependencies. Importing it without vendoring is fine, especially because both repositories belong to DigitalOcean. |
The libvirt-go cgo bindings will likely provide the best stability and error handling capabilities for interacting with libvirt, so we should add the ability to use them. They must be guarded by a build tag.
If built without the tag, all cgo operations will return error stubs.
The text was updated successfully, but these errors were encountered: