Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: allow custom snapshot names #427

Open
maxfliri opened this issue Mar 3, 2022 · 1 comment
Open

Feature request: allow custom snapshot names #427

maxfliri opened this issue Mar 3, 2022 · 1 comment

Comments

@maxfliri
Copy link

maxfliri commented Mar 3, 2022

When I create a VolumeSnapshot, the corresponding DO snapshot created by the CSI is given a name like snapshot-8fb09ea8-d2af-465f-9a84-e121351aaf5b, with the prefix snapshot- followed by a UUID. This makes it hard to understand what a snapshot contains, and which is the corresponding kubernetes VolumeSnapshot.

I'd like to be able to somehow specify the name of the underlying snapshot created by the CSI. This would allow me to give meaningful names to the snapshots, so that I can identify these more easily.

For example, one way of doing this could be using annotations on the VolumeSnapshot metadata:

apiVersion: snapshot.storage.k8s.io/v1beta1
kind: VolumeSnapshot
metadata:
  name: db-snapshot-1
  annotations:
    csi.digitalocean.com/do-snapshot-name: db-snapshot-1
spec:
  source:
    persistentVolumeClaimName: wordpress-html
  volumeSnapshotClassName: do-block-storage

This would instruct the CSI to use db-snapshot-1 as the name for the result DigitalOcean snapshot.

@timoreimann
Copy link
Contributor

We have had similar requests for volumes as well. Totally agree that it'd be cool to assign custom names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants