Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python SnapshotFile #297

Closed
Trickybrain opened this issue Mar 10, 2024 · 2 comments
Closed

python SnapshotFile #297

Trickybrain opened this issue Mar 10, 2024 · 2 comments
Labels

Comments

@nedtwigg nedtwigg changed the title SnapshotFile python SnapshotFile Apr 4, 2024
@nedtwigg nedtwigg transferred this issue from diffplug/selfie-python-wip Apr 4, 2024
@nedtwigg nedtwigg added the py label Apr 4, 2024
@nedtwigg
Copy link
Member

nedtwigg commented Apr 4, 2024

@Trickybrain great work! Looks like you've got the whole snapshot file epic completed! A few improvements which will be important to make the rest work:

  • Snapshot.facetData should be an ArrayMap[String, SnapshotValue]
  • SnapshotFile.snapshots should be an ArrayMap[String, Snapshot]

It needs to be ArrayMap because ArrayMap has a special sort-order for strings, which makes the / character the lowest possible character.

Static types should make this much easier than without them :)

@nedtwigg
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants