Make Cargo.toml compatible with TOML spec #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! @bors-servo r+ |
|
📌 Commit e362e13 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Apr 17, 2016
Make Cargo.toml compatible with TOML spec Hello! I think the Cargo.toml for this crate may not be strictly compliant with the TOML specification - I'm not certain, but it's blowing up in pytoml and my reading of the spec sides with pytoml. The relevant part of the Cargo.toml file: ``` [[test]] name = "format" ``` And the [TOML spec on tables](https://github.com/toml-lang/toml/blob/master/versions/en/toml-v0.4.0.md#table): > They appear in square brackets on a line by themselves So I think pytoml is right to object here, but I'm fairly new to TOML so please let me know if I'm mis-interpreting and I'll go fix pytoml instead :) The incompatibility with pytoml is an issue if you are using cargo-bootstrap, and I've tested that my proposed fix here fixes dhuseby/cargo-bootstrap#13 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/186) <!-- Reviewable:end -->
|
☀️ Test successful - travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I think the Cargo.toml for this crate may not be strictly compliant with the TOML specification - I'm not certain, but it's blowing up in pytoml and my reading of the spec sides with pytoml.
The relevant part of the Cargo.toml file:
And the TOML spec on tables:
So I think pytoml is right to object here, but I'm fairly new to TOML so please let me know if I'm mis-interpreting and I'll go fix pytoml instead :)
The incompatibility with pytoml is an issue if you are using cargo-bootstrap, and I've tested that my proposed fix here fixes dhuseby/cargo-bootstrap#13
This change is