-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Address groups #291
Comments
This is very useful for tracking non-multisig P2WSH, In my case I want to track |
Very interesting idea. Given the design of NBX, I don't expect that to be difficult to add. |
@NicolasDorier Is this still a required feature |
I think it is useful feature yes |
Has there been work done on this? If not I would like to work on it. |
I don't think anyone has worked on this. |
I will begin work on something along these lines. |
Update on this: "INSERT INTO wallets VALUES ('group') ON CONFLICT DO NOTHING
INSERT INTO wallets_wallets VALUES ('existingwallet', 'group') ON CONFLICT DO NOTHING Everytime you query the wallet You don't need to create a new wallet for each address either. You can just attach a script directly to a wallet: "INSERT INTO scripts VALUES ('BTC', 'a1', 'a1');" +
"INSERT INTO wallets_scripts (code, wallet_id, script) VALUES ('BTC', 'group', 'a1');" I guess the main blocker here is that the API doesn't expose any of this and you have to do it through direct database interaction. |
This seems like it could just be added as some extra conditions on the track endpoint. |
This feature will be implemented in the API as two parts:
Tracking
When tracking an individual address, passing an optional
group
value (string) will set a grouping for the address. (ie. "xyz").So if I call track 5 times with 5 different addresses but all 5 times I add ?group=xyz, then all 5 of those addresses will be contained within group xyz.
HD based queries
In addition to current derivationStrategy, a new type will be created:
group-[xyz]
where xyz is the name of the group.Any time a call is made using
group-[xyz]
as the dS, it will perform the query as-if the addresses that were added into the group all came from the same derivationStrategy.The text was updated successfully, but these errors were encountered: