Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of tests for emp::String appear to be disabled #496

Open
mmore500 opened this issue Dec 8, 2023 · 1 comment
Open

Lots of tests for emp::String appear to be disabled #496

mmore500 opened this issue Dec 8, 2023 · 1 comment

Comments

@mmore500
Copy link
Member

mmore500 commented Dec 8, 2023

See i.e.,

We should check if these functions have been removed and, if not, if they are broken.

@mercere99
Copy link
Member

emp::String was built in String.hpp based off of all of the functions in string_utils.hpp. I moved many of the string_util tests over, but some didn't apply cleanly. I do want to go through the rest more to see if any of them should be added, but I don't think it's critical. They weren't removed because of lack of passing or anything like that; they're still active in the string_utils.cpp tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants