Fix multiple inheritance in mem tracking by dynamic casting pointers to void*
#477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 19, 2022
mercere99
approved these changes
Dec 23, 2022
|
Looks like tests are failing. Looking more into dynamic_cast, it apparently ONLY works with polymorphic types, so it won't easily solve the problem here. We need to wrap all of the conversions in some type traits tests to make sure they are polymorphic before we try to resolve them. I'll look into it some more (unless you have time to first) and try to get this resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #476 (hopefully, unless I missed something) by inserting
dynamic_cast<void*>()everywhere a pointer of non-void*type is passed to the pointer tracker withinPtr.