Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image #17

Open
FarisZR opened this issue Jan 23, 2022 · 10 comments
Open

Docker image #17

FarisZR opened this issue Jan 23, 2022 · 10 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@FarisZR
Copy link

FarisZR commented Jan 23, 2022

Certbot has official images on docker hub, also specific images for each official plugin.

Is there any plan to create a docker image for certbot + desec ?

@nils-wisiol
Copy link
Contributor

I currently have no plan, but at least providing a Dockerfile seems a nice thing to do. I'm skeptical if we can afford to actually maintain a Docker image, though. It seems to be high-maintenance because of regular certbot updates and many different supported architectures.

PRs are welcome, of course.

@nils-wisiol nils-wisiol added enhancement New feature or request help wanted Extra attention is needed labels Jan 24, 2022
@FarisZR
Copy link
Author

FarisZR commented Jan 24, 2022

it looks like its really simple to implement.

this worked for me,

FROM certbot/certbot

# Install the DNS plugin
RUN pip3 install certbot-dns-desec

and then just run normal certbot certonly --authenticator dns-desec etc.. and it works!

here is the docker file for dns-ovh
https://hub.docker.com/r/certbot/dns-ovh/dockerfile

@nils-wisiol
Copy link
Contributor

Looks indeed easy enough. I'm wondering though how to deal with releasing images. Can this be done via GitHub actions? The current release workflow is given in our README.

@FarisZR
Copy link
Author

FarisZR commented Feb 12, 2022

since desec already uses github + dockerhub it should be very easy

https://docs.github.com/en/actions/publishing-packages/publishing-docker-images

@Cub0n
Copy link

Cub0n commented Nov 29, 2022

Hello,

I wrote a Dockerfile and an instruction README to build a docker image, according @FarisZR described.
https://github.com/Cub0n/certbot-desec-docker

Please be aware that certbot-dns-desec is not working with the actual version (2.0) of certbot (sth. with zope module failure).

Greetings

@Cub0n
Copy link

Cub0n commented Jan 7, 2023

Dockerfile updated:
Bump Desec Plugin to 1.2.1 and Certbot to 2.1.1.
https://github.com/Cub0n/certbot-desec-docker

@nils-wisiol
Copy link
Contributor

Would you like to create a PR for this? We could first add just the Dockerfile or go all the way and add integration for publication at Dockerhub.

@Cub0n
Copy link

Cub0n commented Jan 10, 2023

Hi,

yes I can do that. I wanted to automize the publishing of the images via Github Workflows and to extend the images to other architectures.
Is it an option to use ghcr.io (GIthub) for providing the images? I have no Docker Hub account, but I think uploading the images to Docker from Github should also be doable.

Thanks
Christian

@nils-wisiol
Copy link
Contributor

Nice! deSEC has a Dockerhub account that we can utilize via the GitHub Action secrets interface.

@Cub0n
Copy link

Cub0n commented Jan 14, 2023

See #24
Please test against Docker Hub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants