Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix reception of realtime advertisements #6103

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: fix reception of realtime advertisements #6103

wants to merge 3 commits into from
+74 −22

Conversation

link2xt
Copy link
Collaborator

@link2xt link2xt commented Oct 23, 2024

Closes #6101

@link2xt
Copy link
Collaborator Author

link2xt commented Oct 23, 2024

Still writing a test.

@link2xt
Copy link
Collaborator Author

link2xt commented Oct 23, 2024

Now it is ready, with a test that fails without the fix.

@link2xt link2xt force-pushed the link2xt/fix-advertisement-reception branch from b79d0ae to b33f61f Compare October 23, 2024 23:58
Septias
Septias approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@Septias Septias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Septias Septias Septias approved these changes

@Hocuri Hocuri Awaiting requested review from Hocuri

@adbenitez adbenitez Awaiting requested review from adbenitez

@iequidoo iequidoo Awaiting requested review from iequidoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Realtime advertisement uses the wrong parent
2 participants
@link2xt @Septias