Skip to content
This repository has been archived by the owner on Jun 26, 2021. It is now read-only.

[FeatureRequest] Prepare for tf 2.0 #165

Open
ORippler opened this issue Jul 24, 2019 · 4 comments
Open

[FeatureRequest] Prepare for tf 2.0 #165

ORippler opened this issue Jul 24, 2019 · 4 comments
Assignees

Comments

@ORippler
Copy link
Collaborator

ORippler commented Jul 24, 2019

Description
Prepare tf and tf-eager backends for migration to tf 2.0

Proposal

  1. deprecate graph mode and remove it when migrating to tf 2.0, as speed loss can and should be minimize with the eventual @tf.function decorator that does jit compilation + optimizaiton.

  2. Refactor tf-eager backend to utilize functions stored inside tf.compat.v2, that are guaranteed to be compatible with tf 2.0.
    Especially use optimizers, variables, losses and metrics stored there.

Additional context
Design changes for tf 2.0 and their discussion can be read up on in the rfcs

@justusschock you want this to be in the PR #102? Or should I make a new one

@justusschock
Copy link
Member

I would prefer a new one based on this PR, since we should merge this separately (to first have an intermediate release supporting the TF1.14 Eager and Graph Mode).

Currently the eager backend is build upon tf.keras.layer. Since TF 2.0 strengthens the usage of tf.keras, I would like to keep it that way, what do you think?

I don't know if we shoud really deprecate the graph mode completely, since it will still be faster than jit-compilation AFAIK.

@justusschock
Copy link
Member

Reminder: Check if inheritance from tf.Module is better than inheritance from tf.keras.Layer [see #102 ]

@justusschock justusschock mentioned this issue Aug 2, 2019
11 tasks
@ORippler
Copy link
Collaborator Author

ORippler commented Oct 1, 2019

tf 2.0 is available now

@justusschock
Copy link
Member

justusschock commented Oct 6, 2019

I think, we should wait with adressing this until #221 is merged, since this should make it easier to derive trainers

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants