Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Reconnect Logic #232

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

dvonthenen
Copy link
Contributor

@dvonthenen dvonthenen commented May 31, 2024

Proposed changes

This is hopefully the last fix for the reconnect logic. We found a couple of things that were preventing the reconnect. Most importantly, we ditched the attempt to reuse the context object. It just flat out wasn't working well. Because we now need to provide a context object on reconnect, it breaks the interface for the live client, but thankful the impact should only be in one place in the user's code.

Have a couple of examples to demonstrate client reuse and misc functionality (please also see #231).

Types of changes

What types of changes does your code introduce to the community Go SDK?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update or tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have lint'ed all of my code using repo standards
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

NA

@dvonthenen dvonthenen merged commit b35c0bf into deepgram:main May 31, 2024
2 checks passed
@dvonthenen dvonthenen deleted the fix-reconnect-logic branch May 31, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants