Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with require js #41

Open
cloudgen opened this issue Oct 31, 2014 · 6 comments
Open

Conflict with require js #41

cloudgen opened this issue Oct 31, 2014 · 6 comments

Comments

@cloudgen
Copy link

Line 7: else if (typeof define == 'function' && typeof define.amd == 'object') define(definition)

create an no name function which then crash the execution of javascript under the environment of requirejs.

@ded
Copy link
Owner

ded commented Nov 2, 2014

this has worked for years and quite possibly a bug with your implementation or the optimizer you're using. unless you can put together a test case i will mark this as won't fix.

@zjiash
Copy link

zjiash commented Nov 26, 2014

I have the same problem when working with requireJs

@normanzb
Copy link

@cloudgen its very likely because you load the module without using requirejs...(eg. include it directly to the page)

what is the purpose having require js in your env without using it

@cloudgen
Copy link
Author

I included a javascript provided by an advertisement provider which include this module directly without using requirejs (The Advertisement provider assume people using their script without any requirejs).

So, the advertisement script crashed everytime I included in my page. This is the circumstance that I cannot modify the code which was hosted somewhere else. The only solution was I had abandoned the advertisement provider.

@jasonkarns
Copy link

looks like this can be closed?

@cloudgen
Copy link
Author

Yes

2016-04-28 21:20 GMT+08:00 Jason Karns [email protected]:

looks like this can be closed?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#41 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants