Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch location to bounds in stored functions. #1123

Open
IanMayo opened this issue Jan 7, 2022 · 0 comments
Open

Switch location to bounds in stored functions. #1123

IanMayo opened this issue Jan 7, 2022 · 0 comments
Labels
Database Database-specific issue Task Package of work Tech Debt Technical Debt

Comments

@IanMayo
Copy link
Member

IanMayo commented Jan 7, 2022

The stored functions allow a search box to be provided.

This box is used to filter measurements that have a location inside the box.

But, in the function definition, the parameter is called location.

Renaming it to bounds is an opportunity to improve the API signature.

The new parameter name has been used in the new detailed_states_for stored procedure, but the others require changing. A patch to apply the change is attached, to be applied using:

git apply /path/to/DevelopDiff_Bounds.txt

Note: this update will probably have to be reflected in Debrief, too.

V1 DevelopDiff_Bounds.txt

V2 DevelopDiff_Bounds2.txt

@IanMayo IanMayo added Tech Debt Technical Debt Task Package of work Database Database-specific issue labels Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Database Database-specific issue Task Package of work Tech Debt Technical Debt
Projects
None yet
Development

No branches or pull requests

1 participant