Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink CSS and JS on deployment #17

Open
cultcom opened this issue Mar 2, 2017 · 1 comment
Open

Shrink CSS and JS on deployment #17

cultcom opened this issue Mar 2, 2017 · 1 comment

Comments

@cultcom
Copy link
Contributor

cultcom commented Mar 2, 2017

bin/cssshrink.sh and bin/jsshrink.sh should be called after deployment to generate .min. files.

unfortunately they need a java runtime environment. Maybe it is a better idea to forget about git and deploy roundcube by the official upstream archives.

@ganto ganto added this to the ansible-roundcube-0.2.0 milestone Mar 9, 2017
@ganto
Copy link
Member

ganto commented Aug 23, 2017

You are right, this is not easy doable when doing the deployment via git. In my PR regarding the upgrade to Roundcube 1.3, I didn't change the deployment method as I worried, this would require a too big change (more or less a complete rewrite).

With the experience of all the stuff that I added and fixed in #24, I guess changing the deployment method to upstream archives still should be considered for the future. It would simplify especially the PHP composer bits and the entire post-deployment tasks including the one mentioned in this issue. I therefore leave it open and unresolved until someone want to implement this.

@ganto ganto removed this from the v0.2.0 milestone Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants