-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ByronBlock / MultiEraBlock explicit era tag #317
Comments
rooooooooob
added a commit
that referenced
this issue
Mar 7, 2024
Update the function to handle Byron EBBs. We still need to figure out what to do in the general deserialize case #317 or if that behavior should just merge this function in there.
This was referenced Mar 7, 2024
As a reminder, the Cardano network specification has a separate CDDL definition from the ledger specification and CML currently doesn't contain any codegen from the networking spec. I'm not sure the networking cddl is a particularly good state (I've never heard good things about it) |
rooooooooob
added a commit
that referenced
this issue
Mar 11, 2024
Update the function to handle Byron EBBs. We still need to figure out what to do in the general deserialize case #317 or if that behavior should just merge this function in there.
SebastienGllmt
pushed a commit
that referenced
this issue
Mar 11, 2024
* MultiEraBlock::from_explicit_network_cbor_bytes EBB Update the function to handle Byron EBBs. We still need to figure out what to do in the general deserialize case #317 or if that behavior should just merge this function in there. * Add comment for MultiEraBlock::hash()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In Byron the era tag wrapping struct is explicitly a part of the CDDL:
For all the other eras there is no mention at all of this outer wrapping struct e.g. Conway (all other eras are similar):
When we retrieve blocks from oura/cardano-net-fetcher we get even these blocks with explicit era tags as if it were:
One approach in order to respect the CDDL it could make sense to keep the tag info in the byron blocks but not touch them in the other eras, and then in
MultiEraBlock
do the check as if it were defined like:or similar.
We currently have
MultiEraBlock::from_explicit_network_cbor_bytes()
to parse using this era tag struct.The text was updated successfully, but these errors were encountered: