Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing license #2

Closed
gildesmarais opened this issue Apr 5, 2022 · 1 comment
Closed

Missing license #2

gildesmarais opened this issue Apr 5, 2022 · 1 comment

Comments

@gildesmarais
Copy link

Hi David!

Thank you for this productivity-boosting extension.

I'd like to add some hooks, but I was wondering how the extension's code is licensed? Could you please add a License (file)? :-)

This could help choosing a license: https://choosealicense.com/

Thank you!

Cheers,
Gil

@dbuezas
Copy link
Owner

dbuezas commented Apr 5, 2022

Hey @gildesmarais!
happy to hear you like it!
I'm adding the permissive MIT license then :)
PRs are welcome and we can discuss if something is confusing with my code. I put some effort in optimising it as much as I could so there's a couple of less obvious parts:

  • I am using my own fork of the React Command Palette package with some fixes (package.json dependency to my own fork, PR here Added showAllCommandsWhenNoneMatches boolean option  asabaylus/react-command-palette#1122)
  • There's quite a lot of memoization
  • Preact instead of react
  • Built through esbuild for speed
  • Commands list is stored as ref to avoid recomputations on react-command-palette
  • I access the react-command-palette input directly to change the query when the "search tabs" (and others) action is selected.

Let me know if you need guidance

@dbuezas dbuezas closed this as completed Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants