Handle var() globally #504
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
davesnx
reviewed
Aug 12, 2024
There was a problem hiding this comment.
That's a cool addition, and wonder if keeping var() in the Parser is still a good idea. It's not part of the spec, which makes it a bit annoying but overall is a better idea than the global render fn.
Mostly because we allow interpolation + variables on the same property. WDYT?
|
I see your point, I think we can put them exactly the same place as we put on them Parser grammar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #417, we handle this the same way as cascading values.
If we detect the use of var(), it will be unsafe and the value will be rendered as string.