Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialization fails on Android 7 Instant App #67

Open
chihweil5 opened this issue Mar 7, 2020 · 0 comments
Open

Initialization fails on Android 7 Instant App #67

chihweil5 opened this issue Mar 7, 2020 · 0 comments

Comments

@chihweil5
Copy link

Describe the bug
Hi, there seems to be an Android framework issue when building instant app on Android 7 where Truskit fails to initialize.
After debugging, the root cause is coming from parsing the ApplicationInfo in this [method].(https://github.com/datatheorem/TrustKit-Android/blob/master/trustkit/src/main/java/com/datatheorem/android/trustkit/TrustKit.java#L231)
When building instant app project, Android 7 somehow fails to create networkSecurityConfigRes=0x. This doesn't happen on the traditional app.

To Reproduce
Here is the branch of a sample instant app modules:
https://github.com/chihweil5/TrustKit-Android/tree/instant-app

The quick tryout solution I made is by changing this condition here, both instant app and app are working on Android 7. I am not sure if this is a proper fix although. Thanks in advance for looking into this issue!

App details:

  • App target SDK: [e.g. 24]
  • App language: [e.g. Kotlin]
  • Android version to reproduce the bug [e.g. Android N]

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant