Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add githubs actions to check compiance with LTS python versions 3.8-3.12 #96

Merged
merged 2 commits into from
Mar 16, 2024

Conversation

rv2931
Copy link
Collaborator

@rv2931 rv2931 commented Mar 6, 2024

Try to install POETRY for python versions 3.8, 3.9, 3.10, 3.11, 3.12

  • 3.12 is failing because of dependency_injection package not compliant with 3.12
  • 3.8 is installing with no error but poetry should not permit this kind of installation as geopandas as a python >= 3.9 restriction
  • 3.11 is installing with no error but is taking a really long time to install, maybe linked to compilation and add of 2 prerequisite gcc and libgeos-dev

@rv2931 rv2931 changed the title [02] Add githubs actions to check compiance with LTS python versions 3.8-3.12 [??] Add githubs actions to check compiance with LTS python versions 3.8-3.12 Mar 6, 2024
@rv2931 rv2931 changed the title [??] Add githubs actions to check compiance with LTS python versions 3.8-3.12 [??04??] Add githubs actions to check compiance with LTS python versions 3.8-3.12 Mar 6, 2024
@romainm13
Copy link
Collaborator

@rv2931

Tu peux pas utiliser matrix à la place dans le Workflow CI ?

Voici un template donné par chatgpt pour donner l'idée

name: CI

on:
  push:
    branches: [main]
  pull_request:
    branches: [main]

jobs:
  build:
    runs-on: ubuntu-latest

    strategy:
      matrix:
        python-version: [3.6, 3.7, 3.8, 3.9]

    steps:
      - name: Checkout code
        uses: actions/checkout@v2

      - name: Set up Python ${{ matrix.python-version }}
        uses: actions/setup-python@v2
        with:
          python-version: ${{ matrix.python-version }}

      - name: Install dependencies
        run: |
          python -m pip install --upgrade pip
          pip install -r requirements.txt

      - name: Run tests
        run: pytest

@rv2931
Copy link
Collaborator Author

rv2931 commented Mar 6, 2024

@rv2931

Tu peux pas utiliser matrix à la place dans le Workflow CI ?

Voici un template donné par chatgpt pour donner l'idée

name: CI

on:
  push:
    branches: [main]
  pull_request:
    branches: [main]

jobs:
  build:
    runs-on: ubuntu-latest

    strategy:
      matrix:
        python-version: [3.6, 3.7, 3.8, 3.9]

    steps:
      - name: Checkout code
        uses: actions/checkout@v2

      - name: Set up Python ${{ matrix.python-version }}
        uses: actions/setup-python@v2
        with:
          python-version: ${{ matrix.python-version }}

      - name: Install dependencies
        run: |
          python -m pip install --upgrade pip
          pip install -r requirements.txt

      - name: Run tests
        run: pytest

@romainm13
Effectivement ça le paraît assez smart. C'est la première GitHub action, je bosse plutôt sur gitlab donc oui pour le moment je suis encore hypra basique
Merci ! Je modifie ça. Sachant qu'il faut rajouter soit un test d'appli soit la stafi de test car même si ça s'installe c'est pas dit qu'il y ait pas un souci au runtime (pour la 3.9 il y a avait des souci de syntaxe par exemple mais installation ok)

@rv2931 rv2931 marked this pull request as draft March 8, 2024 10:29
@rv2931 rv2931 force-pushed the version_supports branch 2 times, most recently from 3d81cd1 to f0c90cb Compare March 13, 2024 22:40
@rv2931 rv2931 changed the title [??04??] Add githubs actions to check compiance with LTS python versions 3.8-3.12 Add githubs actions to check compiance with LTS python versions 3.9-3.12 Mar 13, 2024
@rv2931 rv2931 changed the title Add githubs actions to check compiance with LTS python versions 3.9-3.12 Add githubs actions to check compiance with LTS python versions 3.9-3.11 Mar 13, 2024
@rv2931
Copy link
Collaborator Author

rv2931 commented Mar 13, 2024

J'ai l'impression qu'on est pas mal sur cette PR
J'ai ajouté les tests tox pour chaque version
On a bien la 3.8 qui merde car incompatible avec geopandas et la 3.12 qui merde à cause de dependency-injector, c'était les soucis que j'avais déjà vu et ça se confirme de manière automatique

@rv2931 rv2931 marked this pull request as ready for review March 13, 2024 23:19
fix: add pre-requisites for python packages 3.11/3.12

feat: github actions check python version, use matrix

fix: Docker run chain

fix: gihtub build.yml yaml syntaxe

fix: githab version support problem dix syntax

feat: test with tox

fix: remove pythoon 3.8 version from test supports

feat: supports continue-on-error
@rv2931 rv2931 merged commit 240ba7b into dataforgoodfr:main Mar 16, 2024
3 of 7 checks passed
@rv2931 rv2931 changed the title Add githubs actions to check compiance with LTS python versions 3.9-3.11 Add githubs actions to check compiance with LTS python versions 3.8-3.12 Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants