Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get(), pop(), popitem(), and setdefault() are not thread-safe #99

Open
crusaderky opened this issue Apr 2, 2023 · 0 comments
Open

get(), pop(), popitem(), and setdefault() are not thread-safe #99

crusaderky opened this issue Apr 2, 2023 · 0 comments

Comments

@crusaderky
Copy link
Collaborator

crusaderky commented Apr 2, 2023

#92 left a few important methods of MutableMapping prone to race conditions.

get() may or may not be thread-safe depending on the implementation details in collections.abc.
pop(), popitem() and setdefault() are definitely not thread-safe at the moment of writing.

Worth noting that this does not impact dask/distributed; the exclusion of their usage is enforced by the distributed.spill.AsyncBufferProto API contract.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant