-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More graceful job cancellation #640
Labels
Comments
This sounds like a great improvement. Do you have any interest in making a PR to add this option? |
jacobtomlinson
added
enhancement
New feature or request
help wanted
Extra attention is needed
labels
May 24, 2024
Happy to! Just wanted to check in to make sure there wouldn't be any more hidden gotchas |
Hi! This sounds also perfectly acceptable to me. I don't think there is any case in which we would really like to have a CANCELLED status! Thanks for proposing this, and I think this might be possible with other schedulers too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey all,
This is just a thought for the
SLURMCluster
for now (since that's what I'm familiar with) but similar options may be available in other clusters too. Currently, thecancel_command
in theSLURMJob
class is a bare"scancel"
.dask-jobqueue/dask_jobqueue/slurm.py
Line 15 in 8713202
This means that, even when workers are shutdown completely gracefully, the Slurm job is marked as
CANCELLED
. Instead, if the command werescancel --signal=SIGTERM
the job would be marked asCOMPLETED
. Its possible there could be cases where we would want a job to cancelled, which complicates this somewhat.In the simple case, however, I think this could be implmented with a simple change of
cancel_command
to:It'd be great to get some more thoughts on the implications for this.
The text was updated successfully, but these errors were encountered: