-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated parameters env_extra
, extra
, job_extra
#578
Comments
Thanks @jolange for opening this issue, and thanks again for all you work! As you've probably seen, release are not quite regular here... So a number of releases could take years. What I propose is to make a new major release of dask-jobqueue soon (in the coming days or week), version 0.8.0, as a good number of changes has been commited. Then we could agree on a maximum delay before removing the old parameters. What about 6 months? Or maybe one year? We could say we need to remove the old parameters and deprecation message either after 6 months, either if we plan a new major release until then? |
Sounds good.
6 months sounds enough to me, personally. Of course, given that the deprecation warning has been included in a published release for some time, which should be the case with your plans for a new release. |
0.8.0 version of dask-jobqueue released today. So this issue will be due in 6 months from now, or at the next major release. |
The parameters have been renamed in
env_extra
#575extra
#576job_extra
#577but are still respected, when the newly named parameters are not set. Deprecation warnings are issued if they are still used.
For context, see also #323.
We still need to decide when to finally remove them: Maybe at a fixed date or in terms of number of releases?
The text was updated successfully, but these errors were encountered: