Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated parameters env_extra, extra, job_extra #578

Open
jolange opened this issue Aug 25, 2022 · 3 comments
Open

Remove deprecated parameters env_extra, extra, job_extra #578

jolange opened this issue Aug 25, 2022 · 3 comments
Milestone

Comments

@jolange
Copy link
Contributor

jolange commented Aug 25, 2022

The parameters have been renamed in

but are still respected, when the newly named parameters are not set. Deprecation warnings are issued if they are still used.
For context, see also #323.

We still need to decide when to finally remove them: Maybe at a fixed date or in terms of number of releases?

@guillaumeeb
Copy link
Member

Thanks @jolange for opening this issue, and thanks again for all you work!

As you've probably seen, release are not quite regular here... So a number of releases could take years.

What I propose is to make a new major release of dask-jobqueue soon (in the coming days or week), version 0.8.0, as a good number of changes has been commited. Then we could agree on a maximum delay before removing the old parameters. What about 6 months? Or maybe one year?

We could say we need to remove the old parameters and deprecation message either after 6 months, either if we plan a new major release until then?

@jolange
Copy link
Contributor Author

jolange commented Aug 26, 2022

I propose is to make a new major release of dask-jobqueue soon (in the coming days or week), version 0.8.0

Sounds good.

What about 6 months? Or maybe one year?

6 months sounds enough to me, personally. Of course, given that the deprecation warning has been included in a published release for some time, which should be the case with your plans for a new release.

@guillaumeeb
Copy link
Member

0.8.0 version of dask-jobqueue released today. So this issue will be due in 6 months from now, or at the next major release.

@guillaumeeb guillaumeeb added this to the 0.9 milestone Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants