Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 2.0 TODO #245

Closed
pinkforest opened this issue Dec 18, 2022 · 11 comments
Closed

Release 2.0 TODO #245

pinkforest opened this issue Dec 18, 2022 · 11 comments

Comments

@pinkforest
Copy link
Contributor

pinkforest commented Dec 18, 2022 •
edited
Loading

Batching

Perf-on-Default

Documentation

Testing/Validation

Signing/Verifying API Change

Maintenance

..
@tarcieri
Copy link
Contributor

tarcieri commented Dec 18, 2022 •
edited
Loading

I need to cut a final release of ed25519 v2.0.0 as well. Edit: released!

Related:

This was referenced Jan 5, 2023
Closed
Closed
This was referenced Jan 24, 2023
Closed
Merged
@Chaostheorie
Copy link

Chaostheorie commented Apr 2, 2023 •
edited
Loading

Is there anything stopping a full 2.0.0 release anymore? I recently had problems with the fixed dependency on zeroize =1.3 in the latest stable with the latest stable for secrecy (0.8, depends on zeroize=^1.8).

I would be happy to contribute if anything is still left open for integration

@pinkforest
Copy link
Contributor Author

pinkforest commented Apr 2, 2023 •
edited
Loading

2.0.0-rc.2 should be perfectly usable - it's already released.

We also have further breaking changes so there will be rc.3 at least before SemVer stabilisation period in the wild.

@tarcieri
Copy link
Contributor

tarcieri commented Apr 2, 2023

@Chaostheorie there are still breaking changes happening, for example #293.

In the meantime as @pinkforest the RCs should unblock you.

@Chaostheorie
Copy link

Okay, thank you for the quick response. I'll try to patch it to the release candidate then and look forward to the new stable release.

@Geal Geal mentioned this issue May 29, 2023
Merged
@juchiast
Copy link

juchiast commented Aug 4, 2023

When can we expect a 2.0 release? This crate has the same zeroize issue of curve25519-dalek 3.0

dalek-cryptography/curve25519-dalek#452
solana-labs/solana#26688

@ellttBen ellttBen mentioned this issue Aug 8, 2023
Closed
@matthiasbeyer
Copy link

crates.io already has the 2.0.0 release, but there is no tag yet. Maybe it was forgotten?

@rozbb
Copy link
Contributor

rozbb commented Aug 15, 2023

Hi, indeed we've released 2.0! In addition, we moved this repo over to https://github.com/dalek-cryptography/curve25519-dalek, which is why you don't see the tag here. We're in the process of migrating the issues/PRs from here to there.

@rozbb rozbb closed this as completed Aug 15, 2023
@matthiasbeyer
Copy link

Um... this is dalek-cryptography/ed25519, isn't it? Migrating tags is git push --tags, right? Am I missing something?

@rozbb
Copy link
Contributor

rozbb commented Aug 15, 2023 •
edited
Loading

Indeed it is, but we moved all development to the monorepo mentioned above. Tags can be found there

@matthiasbeyer
Copy link

Ah, sorry... I mis-read your message to link to this same repo. Everything alright.

FirelightFlagboy added a commit to Scille/parsec-cloud that referenced this issue Oct 25, 2023
@FirelightFlagboy
Update ed25519-dalek to 2.0.0 (from 1.0.1)
5b4a600 
- With the update to `2` `ed25519-dalek` not longer depends on
  `[email protected]`.
- Bump `rand` dependency to `0.8` (from `0.7`).
- `ed25519-dalek` now provide the feature `zeroize` that provide
  implementation around the crate `zeroize`. That improve the secrety of
  the private key slightly (and is free).
- `*::generate` where put behind the feature `rand_core`.
- `PublicKey` was renamed by `VerifyingKey`.
- `SigningKey`:
  - Previously named `Keypair`.
  - Implement `Clone`.
  - No longer provide `as_bytes`. it was remplaced by
    `to_bytes`.
  - Implement `TryFrom<&[u8]>`.
  - Implement `From<[u8; 32]>`.
- `Signature::from_bytes` no longer return an error (now it take
  reference to an `[u8; 32]` instead of `[u8]`).

[Changelog](https://github.com/dalek-cryptography/curve25519-dalek/blob/e6675c67ceadecc3e22b561296490f4b7de9ff39/ed25519-dalek/CHANGELOG.md)

> I can't provide the diff between `2.0.0` and `1.0.1` since the project
> as migrate to a different repository.
> C.F: dalek-cryptography/ed25519-dalek#245 (comment)
FirelightFlagboy added a commit to Scille/parsec-cloud that referenced this issue Oct 25, 2023
@FirelightFlagboy
Update ed25519-dalek to 2.0.0 (from 1.0.1)
fa11d5c 
- With the update to `2` `ed25519-dalek` not longer depends on
  `[email protected]`.
- Bump `rand` dependency to `0.8` (from `0.7`).
- `ed25519-dalek` now provide the feature `zeroize` that provide
  implementation around the crate `zeroize`. That improve the secrety of
  the private key slightly (and is free).
- `*::generate` where put behind the feature `rand_core`.
- `PublicKey` was renamed by `VerifyingKey`.
- `SigningKey`:
  - Previously named `Keypair`.
  - Implement `Clone`.
  - No longer provide `as_bytes`. it was remplaced by
    `to_bytes`.
  - Implement `TryFrom<&[u8]>`.
  - Implement `From<[u8; 32]>`.
- `Signature::from_bytes` no longer return an error (now it take
  reference to an `[u8; 32]` instead of `[u8]`).

[Changelog](https://github.com/dalek-cryptography/curve25519-dalek/blob/e6675c67ceadecc3e22b561296490f4b7de9ff39/ed25519-dalek/CHANGELOG.md)

> I can't provide the diff between `2.0.0` and `1.0.1` since the project
> as migrate to a different repository.
> C.F: dalek-cryptography/ed25519-dalek#245 (comment)
FirelightFlagboy added a commit to Scille/parsec-cloud that referenced this issue Oct 26, 2023
@FirelightFlagboy
Update ed25519-dalek to 2.0.0 (from 1.0.1)
84a4d91 
- With the update to `2` `ed25519-dalek` not longer depends on
  `[email protected]`.
- Bump `rand` dependency to `0.8` (from `0.7`).
- `ed25519-dalek` now provide the feature `zeroize` that provide
  implementation around the crate `zeroize`. That improve the secrety of
  the private key slightly (and is free).
- `*::generate` where put behind the feature `rand_core`.
- `PublicKey` was renamed by `VerifyingKey`.
- `SigningKey`:
  - Previously named `Keypair`.
  - Implement `Clone`.
  - No longer provide `as_bytes`. it was remplaced by
    `to_bytes`.
  - Implement `TryFrom<&[u8]>`.
  - Implement `From<[u8; 32]>`.
- `Signature::from_bytes` no longer return an error (now it take
  reference to an `[u8; 32]` instead of `[u8]`).

[Changelog](https://github.com/dalek-cryptography/curve25519-dalek/blob/e6675c67ceadecc3e22b561296490f4b7de9ff39/ed25519-dalek/CHANGELOG.md)

> I can't provide the diff between `2.0.0` and `1.0.1` since the project
> as migrate to a different repository.
> C.F: dalek-cryptography/ed25519-dalek#245 (comment)
FirelightFlagboy added a commit to Scille/parsec-cloud that referenced this issue Oct 30, 2023
@FirelightFlagboy
Update ed25519-dalek to 2.0.0 (from 1.0.1)
c9a39ce 
- With the update to `2` `ed25519-dalek` not longer depends on
  `[email protected]`.
- Bump `rand` dependency to `0.8` (from `0.7`).
- `ed25519-dalek` now provide the feature `zeroize` that provide
  implementation around the crate `zeroize`. That improve the secrety of
  the private key slightly (and is free).
- `*::generate` where put behind the feature `rand_core`.
- `PublicKey` was renamed by `VerifyingKey`.
- `SigningKey`:
  - Previously named `Keypair`.
  - Implement `Clone`.
  - No longer provide `as_bytes`. it was remplaced by
    `to_bytes`.
  - Implement `TryFrom<&[u8]>`.
  - Implement `From<[u8; 32]>`.
- `Signature::from_bytes` no longer return an error (now it take
  reference to an `[u8; 32]` instead of `[u8]`).

[Changelog](https://github.com/dalek-cryptography/curve25519-dalek/blob/e6675c67ceadecc3e22b561296490f4b7de9ff39/ed25519-dalek/CHANGELOG.md)

> I can't provide the diff between `2.0.0` and `1.0.1` since the project
> as migrate to a different repository.
> C.F: dalek-cryptography/ed25519-dalek#245 (comment)
FirelightFlagboy added a commit to Scille/parsec-cloud that referenced this issue Nov 2, 2023
@FirelightFlagboy
Update ed25519-dalek to 2.0.0 (from 1.0.1)
2612ea8 
- With the update to `2` `ed25519-dalek` not longer depends on
  `[email protected]`.
- Bump `rand` dependency to `0.8` (from `0.7`).
- `ed25519-dalek` now provide the feature `zeroize` that provide
  implementation around the crate `zeroize`. That improve the secrety of
  the private key slightly (and is free).
- `*::generate` where put behind the feature `rand_core`.
- `PublicKey` was renamed by `VerifyingKey`.
- `SigningKey`:
  - Previously named `Keypair`.
  - Implement `Clone`.
  - No longer provide `as_bytes`. it was remplaced by
    `to_bytes`.
  - Implement `TryFrom<&[u8]>`.
  - Implement `From<[u8; 32]>`.
- `Signature::from_bytes` no longer return an error (now it take
  reference to an `[u8; 32]` instead of `[u8]`).

[Changelog](https://github.com/dalek-cryptography/curve25519-dalek/blob/e6675c67ceadecc3e22b561296490f4b7de9ff39/ed25519-dalek/CHANGELOG.md)

> I can't provide the diff between `2.0.0` and `1.0.1` since the project
> as migrate to a different repository.
> C.F: dalek-cryptography/ed25519-dalek#245 (comment)
github-merge-queue bot pushed a commit to Scille/parsec-cloud that referenced this issue Nov 2, 2023
@FirelightFlagboy
Update ed25519-dalek to 2.0.0 (from 1.0.1)
a4dd703 
- With the update to `2` `ed25519-dalek` not longer depends on
  `[email protected]`.
- Bump `rand` dependency to `0.8` (from `0.7`).
- `ed25519-dalek` now provide the feature `zeroize` that provide
  implementation around the crate `zeroize`. That improve the secrety of
  the private key slightly (and is free).
- `*::generate` where put behind the feature `rand_core`.
- `PublicKey` was renamed by `VerifyingKey`.
- `SigningKey`:
  - Previously named `Keypair`.
  - Implement `Clone`.
  - No longer provide `as_bytes`. it was remplaced by
    `to_bytes`.
  - Implement `TryFrom<&[u8]>`.
  - Implement `From<[u8; 32]>`.
- `Signature::from_bytes` no longer return an error (now it take
  reference to an `[u8; 32]` instead of `[u8]`).

[Changelog](https://github.com/dalek-cryptography/curve25519-dalek/blob/e6675c67ceadecc3e22b561296490f4b7de9ff39/ed25519-dalek/CHANGELOG.md)

> I can't provide the diff between `2.0.0` and `1.0.1` since the project
> as migrate to a different repository.
> C.F: dalek-cryptography/ed25519-dalek#245 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@tarcieri @matthiasbeyer @rozbb @juchiast @pinkforest @Chaostheorie