Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot pinch to zoom on touch screens in graph view in GUI #1947

Open
jfrost-mo opened this issue Sep 24, 2024 · 5 comments
Open

Cannot pinch to zoom on touch screens in graph view in GUI #1947

jfrost-mo opened this issue Sep 24, 2024 · 5 comments
Labels
bug Something isn't working
Milestone

Comments

@jfrost-mo
Copy link

Description

A common interaction pattern in touch interfaces is pinching to zoom. This does not work in the graph view of the cylc GUI.

Reproducible Example

  1. Open a workflow in cylc GUI on a touch screen device, like a touchscreen laptop or a smartphone.
  2. Open graph view.
  3. Try to zoom via touch.

Expected Behaviour

Can zoom with touch controls, in a similar way to most other apps. Google maps is a good example of how this scrolling should work.

@jfrost-mo jfrost-mo added the bug Something isn't working label Sep 24, 2024
@oliver-sanders
Copy link
Member

oliver-sanders commented Sep 25, 2024

Hmmm.

I'm pretty sure I tried this out when the graph view was first added, but that was a while ago and we have no tests for touch screen gestures.

The pan/zoom functionality comes from an external library. If you get the chance, could you try these examples to see whether they work for you?

@jfrost-mo
Copy link
Author

Testing on a NIWA laptop (which are touchscreen!) the inline example doesn't work, the same as Cylc, while the mobile one does. This was tested in Chrome and Edge.

@oliver-sanders
Copy link
Member

oliver-sanders commented Sep 26, 2024

Great, thanks for checking. To close this, we can copy the event handling of the second example onto the graph view and see what we can do to test this in Cypress.

@oliver-sanders oliver-sanders added this to the Pending milestone Sep 26, 2024
@jfrost-mo

This comment was marked as off-topic.

@oliver-sanders
Copy link
Member

Attempt after #1810

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants