Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flake8-type-checking #182

Closed
5 tasks done
oliver-sanders opened this issue Oct 16, 2023 · 0 comments · Fixed by cylc/cylc-uiserver#513, cylc/cylc-rose#257, metomi/rose#2730 or metomi/isodatetime#239
Closed
5 tasks done

flake8-type-checking #182

oliver-sanders opened this issue Oct 16, 2023 · 0 comments · Fixed by cylc/cylc-uiserver#513, cylc/cylc-rose#257, metomi/rose#2730 or metomi/isodatetime#239
Assignees
@markgrahamdawson

Comments

@oliver-sanders
Copy link
Member

oliver-sanders commented Oct 16, 2023 •
edited by markgrahamdawson
Loading

Turns out we were importing a bunch of things for type checking without putting them behind if TYPE_CHECKING blocks. This was slowing Cylc runtime down. This PR addresses the issue for cylc-flow and adds a flake8 check to prevent this from happening again:

cylc/cylc-flow#5770

Quick easy fix!

Suggest adding the flake8-type-checking plugin to our other repos and fixing anything it complains about:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markgrahamdawson markgrahamdawson

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@markgrahamdawson @oliver-sanders