Add Toggle for NewModule Form and skipCRDs Support in Backend #616
+28
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rontend NewModule form toggle
|
@quest-bot loot #602 |
|
petar-cvit
requested changes
Oct 13, 2024
There was a problem hiding this comment.
The skip crds values from the UI is not properly passed when creating a module and is never applied.
Also, since you are changing the CRD, run make manifests to generate manifests in cyclops-ctrl/config/crd/bases, and make sure the value is properly mapped in the kubernetes cluster
|
@petar-cvit Can you tell me the changes required in the backend |
$ make manifests
make: *** No rule to make target 'manifests'. Stop.It's giving this output when running inside the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #602
📑 Description
✅ Checks
Screenshots