Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnderlyingCoins balance does not properly use decimals for balance calculation #17

Open
0seba opened this issue Mar 13, 2023 · 0 comments

Comments

@0seba
Copy link

0seba commented Mar 13, 2023

When calculating the balance of the underlying coins here the decimals are not used (which causes it default to 18 afaik), one example in which this causes problems is in 3CRV metapools, which causes the balance to be $10^{12}$ times less than the real value. Did not find this issue in the exchangeUnderlying handler

Here is the code of the line with the problem

coin.balance = balances ? decimal.fromBigInt(balances![i]) : decimal.ZERO
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant