-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove default Privacy selection during group creation #467
Comments
I've made the change so that no radio button is checked. I added the A radio with no default value feels odd to me. The HTML spec recommends against it. From https://html.spec.whatwg.org/multipage/input.html#attr-input-required:
I'm unsure what else to suggest in its place. |
We'd like to revert this change so that the 'Public' radio button is once again checked by default. Thanks! |
Reverted in cuny-academic-commons/openlab-theme@ee0ccd6 I'll move this out of the 1.6.x for future consideration. |
During group creation, you're asked to configure 'Privacy Settings':
By default, the 'Public' radio button is checked.
To encourage more intentional choices around privacy, we will provide no default value at all. When loading this page, no radio button will be checked.
We'll probably want to add some client-side validation, since the default state of this part of the form will not be valid. We'll piggyback on existing browser validation.
At the moment we're only building this new feature for CBOX OpenLab.
The text was updated successfully, but these errors were encountered: