Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update with --due seems to be off by one day #3

Open
adius opened this issue Aug 14, 2017 · 6 comments
Open

update with --due seems to be off by one day #3

adius opened this issue Aug 14, 2017 · 6 comments
Labels

Comments

@adius
Copy link

adius commented Aug 14, 2017

When I run ghm milestone update 2017-W33 --due 2017-08-21 the due date on GitHub is displayed as 2017-08-20. Seems like a misunderstanding what the term due date means. (inclusive or exclusive) 🙈

@getvega
Copy link
Contributor

getvega commented Aug 16, 2017

Hmm I do not process the date at all - we just forward it to the Github API which parses it in UTC. https://developer.github.com/v3/issues/milestones/#update-a-milestone

So I think it's more of a timezone issue here we should read it using machine's timezone and forward it properly. Is it what happened to you @adius? (what's your timezone?)

@getvega getvega added the bug label Aug 16, 2017
@adius
Copy link
Author

adius commented Aug 16, 2017

All my digital devices are set to UTC. Exactly to avoid any timezone issues =D

@adius
Copy link
Author

adius commented Aug 16, 2017

I ran ghm milestone update 2017-W33 --due 2017-08-22 and the GitHub milestones API returns "due_on": "2017-08-21T07:00:00Z",

@adius
Copy link
Author

adius commented Aug 16, 2017

Also running ghm milestone update 2017-W33 --due '2017-08-21T00:00:00.000' doesn't change it

@getvega
Copy link
Contributor

getvega commented Aug 23, 2017

@adius would you be interested in becoming a maintainer of this project?

@adius
Copy link
Author

adius commented Aug 23, 2017

If you are OK with me changing the style guide to https://github.com/style-guides/JavaScript 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants