Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bias correction #185

Open
maxnoe opened this issue Jun 30, 2022 · 1 comment
Open

Bias correction #185

maxnoe opened this issue Jun 30, 2022 · 1 comment
Labels
discussion Issues that open a discussion without any planned modification to the code enhancement New feature or request

Comments

@maxnoe
Copy link
Member

maxnoe commented Jun 30, 2022

Is bias correction something wanted in pyirf?

If so, where should it be implemented?
Directly as an option in the resolution functions?
Or as separate functions?

Originally posted by @vuillaut in #184

@HealthyPear
Copy link
Member

I think we could generalise this option in a similar way to what we did for resolution:

  • a module or a section of it for bias correction methods (or applied to specific cases, like energy)
  • the resolution function calls a keyword argument which sets which function to use

Regarding specifically what CTAMARS does see here.
This happens after cuts optimisation, so in that case it fits with pyirf's scope.

@HealthyPear HealthyPear added enhancement New feature or request discussion Issues that open a discussion without any planned modification to the code labels Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Issues that open a discussion without any planned modification to the code enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants