Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix workflow dependency when publishing a new release branch #605

Open
straight-shoota opened this issue Apr 11, 2022 · 0 comments
Open
Labels

Comments

@straight-shoota
Copy link
Member

#561 automated the process of publishing release branches.

There is a problem with dependencies: Deploy config finishes before Deploy book and in the time between, redirects to the new releaset (for example /reference -> /reference/1.4) are already in place but the target is not yet available.

So we need to delay the Deploy config workflow to run only after Deploy book has finished successfully. I suppose we could use the workflow_run trigger for this, but then we can't depend on the create branch trigger.
This means the deploy config would run on every build of a release branch. Maybe that's okay okay. Maybe we can still find a way to run it only when a new release branch is created (for example, check with S3 if the release folder already exists before pushing it). But that's definitely more complex. Probably best is to start with a config renewal on every build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant