Aurora DBInstance .spec.forProvider field is modified and makes the CR invalid

[drewwells]

Crossplane is setting spec.forProvider.{masterUsername,kmsKeyID,port} on a spec that is disallowed when those fields are set.

What happened?

Crossplane attempts to recreate a deleted aurora instance and fails because the forProvider block was modified to an invalid state. kmsKeyID, masterusername and port were populated.

For example, these errors are seen:

The requested DB Instance will be a member of a DB Cluster. Set master user name for the DB Cluster.

create failed: cannot create DBInstance in AWS: InvalidParameterCombination:
      The requested DB Instance will be a member of a DB Cluster. Set database endpoint
      port number for the DB Cluster.\n\tstatus code: 400

How can we reproduce it?

Provision an aurora dbcluster and dbinstance
Delete the dbinstance from AWS console
Trigger crossplane to reconcile the dbinstance which is missing an aws resource now
Crossplane reports confusing errors that the dbcluster is missing fields port, masterUsername, and kmsKeyID. It's actually because the dbinstance now includes those fields.

What environment did it happen in?

provider-aws version: 0.46.0
crossplane: 1.17.0

[MisterMX]

Crossplane does not support external deletion of resources. The deletion process should always be triggered from within Crossplane.

If there is a way to prevent this error from happening without breaking existing implementations feel free to open a pull request.

[drewwells]

Do you know why the provider is modifying the spec fields? Its changing fields to make the spec configuration invalid Drew On October 22, 2024, Anthony Sottile ***@***.***> wrote: Crossplane does not support external deletion of resources. The deletion process should always be triggered from within Crossplane. If there is a way to prevent this error from happening without breaking existing implementations feel free to open a pull request. — Reply to this email directly, view it on GitHub <#2106 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAB2ME2R34JQOW35D4NXV7TZ4ZFUVAVCNFSM6AAAAABP73RLCKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRZGI2TMNRQG4> . You are receiving this because you authored the thread.Message ID: ***@***.***>