Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example code is broken #57

Open
thoec opened this issue Nov 27, 2023 · 2 comments
Open

Example code is broken #57

thoec opened this issue Nov 27, 2023 · 2 comments

Comments

@thoec
Copy link

thoec commented Nov 27, 2023

example/composition.yaml:
fromFieldPath: "location"

should be (as in README.md)
fromFieldPath: "spec.location"
@thoec
Copy link
Author

thoec commented Nov 27, 2023

Also, the example code could be better. I propose to use another default for spec.forProvider.region so that it is obvious what the result of the function is.

@phclark
Copy link

phclark commented Dec 9, 2023

#63 should fix the incorrect fromFieldPath, also adds a few other examples of usage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phclark @thoec