[4.0] Manual gateway orders appearing in Stripe

[jonleverrier]

Description

When our store administrators create a manual order and make a payment against the order using a manual gateway (we're using this to allow customers to pay by 30 days invoice), there is a line in the transaction tab that says "card payment failed", even though we've not interacted with the stripe gateway.

This is also happening on the front-end too when customers choose to pay by manual gateway.

All orders that have been paid for using the manual gateway appear in Stripe as incomplete!

Steps to reproduce

1. Setup a manual and stripe gateway
2. Put through a manual order
3. Pay for it using a manual gateway
4. Notice how in the transaction tab, there is a line that says card payment failed
5. Notice how in the Stripe dashboard the order which was paid for using the manual gateway is in there!

Additional info

• Craft CMS version:
• Stripe for Craft Commerce version:
• PHP version:
• Database driver & version:
• Plugins & versions:

[lukeholder]

Thanks, this has been fixed for the next release.

To get the fixes early, change your craftcms/commerce and craftcms/commerce-stripe requirements in composer.json to:

"require": {
  "craftcms/commerce": "dev-develop#04d8249281d801992f9acc6799db56848c16b4b1 as 4.3.0",
  "craftcms/commerce-
stripe
": "dev-develop#b10503188c4c64efe3f20baf300a669cfbcac16e as 4.0.1",
  "...": "..."
}

[jonleverrier]

Thanks @lukeholder - that was super quick! If I change my composer.json to get the changes early, do I have to change something back when the new versions of commerce and commerce-stripe come out?

[lukeholder]

Sorry, make sure to run composer update once updating the composer.json

When the new versions come out, restore the version constraint or use the new version numbers only.

[jonleverrier]

Perfect- thank you

[jonleverrier]

Hey @lukeholder. Did the fix for this make it into v4.0.1.1? I'm guessing it did (b105031), but just double checking

[lukeholder]

@jonleverrier yes use the latest version