-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make send_packet
method as private
#1243
Comments
Thanks for the report! Currently, This requires port management to fix this completely. We need to include port capability check in |
Adding more context. We will probably need #465 and make sure, We will most likely need a way to create |
Bug Summary
The
send_packet
method is public which can be used to send packets without token transfers. But usingsend_packet
, a transfer packet can be spoofed without locking the tokens. So essentially, users can just callsend_packet
and get tokens on destination without token transfer on source.Details
The
send_packet
method here should prolly be private or be removed once we have port management which will enable us to just usesend_transfer
with different port for cross chain messaging.ibc-rs/ibc-core/ics04-channel/src/handler/send_packet.rs
Line 20 in dcf8c36
Version
0.50.0
The text was updated successfully, but these errors were encountered: