Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate forwarding hops validation for transfer and packet data messages #6658

Closed
3 tasks
DimitrisJim opened this issue Jun 20, 2024 · 1 comment
Closed
3 tasks

Consolidate forwarding hops validation for transfer and packet data messages #6658

DimitrisJim opened this issue Jun 20, 2024 · 1 comment
Assignees
@gjermundgaraba
Labels
20-transfer type: code hygiene Clean up code but without changing functionality or interfaces
Milestone
ICS20 v2 (path fo...

Comments

@DimitrisJim
Copy link
Contributor

Ref #6655 (comment)

Nit (can be done in a follow-up, no need to block this PR): Since this hops validation is also done in ForwardingPacketData Validate, maybe it could be extracted into a separate function, but still care of slight differences in the error messages (e.g. forwarding vs forwarding packet data), if we want that.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@DimitrisJim DimitrisJim added 20-transfer type: code hygiene Clean up code but without changing functionality or interfaces labels Jun 20, 2024
@DimitrisJim DimitrisJim mentioned this issue Jun 20, 2024
Merged
10 tasks
@gjermundgaraba gjermundgaraba self-assigned this Jun 25, 2024
@gjermundgaraba gjermundgaraba mentioned this issue Jun 25, 2024
Merged
10 tasks
@crodriguezvega
Copy link
Contributor

Closed by #6695

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gjermundgaraba gjermundgaraba

Labels
20-transfer type: code hygiene Clean up code but without changing functionality or interfaces
Projects
ibc-go
Archived in project
Milestone
ICS20 v2 (path forwarding) beta
Development

No branches or pull requests
3 participants
@gjermundgaraba @crodriguezvega @DimitrisJim